Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/21105 )
Change subject: IMPALA-12845: Crash with DESCRIBE on a complex type from an Iceberg table ...................................................................... Patch Set 2: (1 comment) Just a nit, to make it more clear what was changed in DescribeTableStmt::analyze(). http://gerrit.cloudera.org:8080/#/c/21105/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21105/2//COMMIT_MSG@39 PS2, Line 39: and after : analysis Maybe this part of the commit message could be rephrased after the change in the analyze() function. What about skipping this part ".. and after analysis.."? -- To view, visit http://gerrit.cloudera.org:8080/21105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5eda21a41167cc1fda183aa16fd6276a6a16f5d3 Gerrit-Change-Number: 21105 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 06 Mar 2024 12:47:24 +0000 Gerrit-HasComments: Yes
