Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21107 )
Change subject: IMPALA-12678: Deflake test_skipping_batching_events ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21107/1/be/src/util/backend-gflag-util.cc File be/src/util/backend-gflag-util.cc: http://gerrit.cloudera.org:8080/#/c/21107/1/be/src/util/backend-gflag-util.cc@119 PS1, Line 119: DECLARE_string(debug_actions); nit: CatalogD is already capable of taking debug_actions as an argument. https://github.com/apache/impala/blob/master/tests/custom_cluster/test_thrift_debug_string_exception.py#L26 So I think this is not required http://gerrit.cloudera.org:8080/#/c/21107/1/tests/common/impala_cluster.py File tests/common/impala_cluster.py: http://gerrit.cloudera.org:8080/#/c/21107/1/tests/common/impala_cluster.py@603 PS1, Line 603: def set_jvm_log_level(self, class_name, level): Currently, we don't have any usage of this right? -- To view, visit http://gerrit.cloudera.org:8080/21107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia6e4cd1e9492e3ce75f5089038b90d0af4fbdb0f Gerrit-Change-Number: 21107 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 05 Mar 2024 19:17:00 +0000 Gerrit-HasComments: Yes
