Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21107 )
Change subject: IMPALA-12678: Deflake test_skipping_batching_events ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21107/1/be/src/util/backend-gflag-util.cc File be/src/util/backend-gflag-util.cc: http://gerrit.cloudera.org:8080/#/c/21107/1/be/src/util/backend-gflag-util.cc@119 PS1, Line 119: DECLARE_string(debug_actions); > nit: CatalogD is already capable of taking debug_actions as an argument. ht This is needed to pass debug_action flag to JVM code via BackendConfig.java. For Java code, we usually pass debug_action via query option. But this patch inject the delay in CatalogD, irrespective of query execution. So we need to pass it through flag. THRIFT_DEBUG_STRING that you point is a debug action point in C++ code, therefore it does not need to propagate via BackendGflags.thrift and BackendConfig.java. http://gerrit.cloudera.org:8080/#/c/21107/1/tests/common/impala_cluster.py File tests/common/impala_cluster.py: http://gerrit.cloudera.org:8080/#/c/21107/1/tests/common/impala_cluster.py@603 PS1, Line 603: def set_jvm_log_level(self, class_name, level): > Currently, we don't have any usage of this right? Not for this patch specifically. But Impalad also has JVM like Catalogd, so this is relevant and might be useful for other custom cluster test in the future. -- To view, visit http://gerrit.cloudera.org:8080/21107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia6e4cd1e9492e3ce75f5089038b90d0af4fbdb0f Gerrit-Change-Number: 21107 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 05 Mar 2024 19:28:51 +0000 Gerrit-HasComments: Yes
