Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21110 )

Change subject: IMPALA-12878: Report invalid query if finalized
......................................................................


Patch Set 3:

(1 comment)

Do you mind testing by running exhaustive test in your local machine?

impala-py.test --exploration=exhaustive query_test/test_cancellation.py

http://gerrit.cloudera.org:8080/#/c/21110/3/tests/query_test/test_cancellation.py
File tests/query_test/test_cancellation.py:

http://gerrit.cloudera.org:8080/#/c/21110/3/tests/query_test/test_cancellation.py@287
PS3, Line 287: cls.ImpalaTestMatrix.add_constraint(
             :         lambda v: v.get_value('fail_rpc_action') == 
FAIL_RPC_ACTIONS[0])
Not related with this patch, but I see this when I run exhaustive test over 
this test_cancellation.py

WARNING  MainThread: No test vectors generated for test 'test_cancel_sort'. 
Check constraints and input vectors

Is this a bug because fail_rpc_action dimention is not specified?



--
To view, visit http://gerrit.cloudera.org:8080/21110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd
Gerrit-Change-Number: 21110
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Thu, 07 Mar 2024 00:11:20 +0000
Gerrit-HasComments: Yes

Reply via email to