Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21110 )
Change subject: IMPALA-12878: Report invalid query if finalized ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21110/3/tests/query_test/test_cancellation.py File tests/query_test/test_cancellation.py: http://gerrit.cloudera.org:8080/#/c/21110/3/tests/query_test/test_cancellation.py@108 PS3, Line 108: ImpalaTestDimension('delay_finalize_action', *DELAY_FINALIZE_ACTIONS)) > This matrix runs so many tests. I'm tempted to create a special test for th I think that is a good idea. Create separate test class with DELAY_FINALIZE_ACTIONS fixed to 'FINALIZE_INFLIGHT_QUERY:SLEEP@10' and other dimensions constrained to single value. http://gerrit.cloudera.org:8080/#/c/21110/3/tests/query_test/test_cancellation.py@287 PS3, Line 287: cls.ImpalaTestMatrix.add_constraint( : lambda v: v.get_value('fail_rpc_action') == FAIL_RPC_ACTIONS[0]) > I don't get that. Not sure what's happening. Nevermind, its a mistake on my code tree. -- To view, visit http://gerrit.cloudera.org:8080/21110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bf910f499147a09352f9dcb755037b0d8616dfd Gerrit-Change-Number: 21110 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 07 Mar 2024 01:16:12 +0000 Gerrit-HasComments: Yes
