Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 )
Change subject: IMPALA-12426: Query History Table ...................................................................... Patch Set 36: (1 comment) http://gerrit.cloudera.org:8080/#/c/20770/35/be/src/util/sql-util.cc File be/src/util/sql-util.cc: http://gerrit.cloudera.org:8080/#/c/20770/35/be/src/util/sql-util.cc@57 PS35, Line 57: const auto& escape_iter = CHARS_TO_ESCAPE.find(*iter); A switch statement is a lot faster than hash map lookup. It wasn't that verbose, I'd prefer to keep the switch statement. -- To view, visit http://gerrit.cloudera.org:8080/20770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d2da9d450fba4e789400cfa62927fc25d34f844 Gerrit-Change-Number: 20770 Gerrit-PatchSet: 36 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 07 Mar 2024 23:37:28 +0000 Gerrit-HasComments: Yes
