Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 )
Change subject: IMPALA-12426: Query History Table ...................................................................... Patch Set 36: (2 comments) http://gerrit.cloudera.org:8080/#/c/20770/36/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/20770/36/be/src/service/workload-management.cc@195 PS36, Line 195: const string FQ_TABLE = StrCat(FLAGS_query_log_table_db, ".", FLAGS_query_log_table_name); gflags can't have been set from the CLI during static initialization. Which means these all need to be helper functions instead of static variables. And probably need more test coverage. We have examples of setting gflags during tests. Which also means things like https://github.com/apache/impala/blob/master/be/src/catalog/catalogd-main.cc#L59-L64 do absolutely nothing. They get overridden by google::ParseCommandLineFlags in InitCommonRuntime. http://gerrit.cloudera.org:8080/#/c/20770/36/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/20770/36/common/thrift/metrics.json@3765 PS36, Line 3765: "key": "impala-server.completed_queries.written" Use dashes in query keys, not underscores. -- To view, visit http://gerrit.cloudera.org:8080/20770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d2da9d450fba4e789400cfa62927fc25d34f844 Gerrit-Change-Number: 20770 Gerrit-PatchSet: 36 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 08 Mar 2024 00:50:31 +0000 Gerrit-HasComments: Yes
