Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10275 )
Change subject: IMPALA-6949: Add the option to start the minicluster with EC enabled ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/10275/2/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/10275/2/bin/impala-config.sh@449 PS2, Line 449: elif [ "${TARGET_FILESYSTEM}" = "hdfs-ec" ]; then By making this its own TARGET_FILESYSTEM, you end up disabling a bunch of tests that rely on TARGET_FILESYSTEM==hdfs. Are you loosening those if statements? Or would it be better to have this as a different flag axis? http://gerrit.cloudera.org:8080/#/c/10275/2/bin/impala-config.sh@454 PS2, Line 454: echo "Valid values are: hdfs, isilon, s3, local" Please update? http://gerrit.cloudera.org:8080/#/c/10275/2/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/10275/2/bin/run-all-tests.sh@71 PS2, Line 71: FE_TEST=false Add a comment about why? http://gerrit.cloudera.org:8080/#/c/10275/2/testdata/bin/setup-hdfs-env.sh File testdata/bin/setup-hdfs-env.sh: http://gerrit.cloudera.org:8080/#/c/10275/2/testdata/bin/setup-hdfs-env.sh@80 PS2, Line 80: hdfs ec -unsetPolicy -path "${HDFS_EC_PATH:=/test-warehouse/}" Do you know what this does underneath the covers? Do we need to block while it un-erasure-codes things? i.e., do we believe going back and forth is going to work? -- To view, visit http://gerrit.cloudera.org:8080/10275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I397aed491354be21b0a8441ca671232dca25146c Gerrit-Change-Number: 10275 Gerrit-PatchSet: 2 Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Tue, 01 May 2018 23:17:10 +0000 Gerrit-HasComments: Yes
