Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10275 )
Change subject: IMPALA-6949: Add the option to start the minicluster with EC enabled ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/10275/3/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/10275/3/bin/impala-config.sh@450 PS3, Line 450: elif [ "${TARGET_FILESYSTEM}" == "hdfs" ]; then > I'm trying this out and found that == don't work with zsh. Done http://gerrit.cloudera.org:8080/#/c/10275/3/bin/impala-config.sh@451 PS3, Line 451: if [[ "${ERASURE_CODING}" = true ]]; then > I think we should error out or warn here if MINICLUSTER_PROFILE < 3. I.e., Done http://gerrit.cloudera.org:8080/#/c/10275/3/testdata/bin/setup-hdfs-env.sh File testdata/bin/setup-hdfs-env.sh: http://gerrit.cloudera.org:8080/#/c/10275/3/testdata/bin/setup-hdfs-env.sh@80 PS3, Line 80: HDFS_EC_PATH > Please add: I agree. I don't think it makes sense to unset it here, because it's not going to do anything. Removed. http://gerrit.cloudera.org:8080/#/c/10275/2/testdata/cluster/node_templates/common/etc/hadoop/conf/hdfs-site.xml.tmpl File testdata/cluster/node_templates/common/etc/hadoop/conf/hdfs-site.xml.tmpl: http://gerrit.cloudera.org:8080/#/c/10275/2/testdata/cluster/node_templates/common/etc/hadoop/conf/hdfs-site.xml.tmpl@26 PS2, Line 26: <name>cloudera.erasure_coding.enabled</name> > Add: Done -- To view, visit http://gerrit.cloudera.org:8080/10275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I397aed491354be21b0a8441ca671232dca25146c Gerrit-Change-Number: 10275 Gerrit-PatchSet: 3 Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Fri, 04 May 2018 01:40:35 +0000 Gerrit-HasComments: Yes
