Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20986 )
Change subject: IMPALA-12782: Show info of the event processing in /events webUI ...................................................................... Patch Set 9: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/20986/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/20986/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1192 PS3, Line 1192: * @param events List of NotificationEvents I am ok with merging the current state, but I find it pretty confusing. Doing this in a synchronized way may not be really necessary but would make to logic easier to understand. > and the recent 10 failures I think that storing at least 1 failure is the most critical as generally there should be 0 failures. A few more thoughts for storing failures: - after IMPALA-12832 this part of the code would not see table level failures that were solved with invalidating the table. It would be nice to store those too - besides storing the event the call stack would be also useful http://gerrit.cloudera.org:8080/#/c/20986/9/www/events.tmpl File www/events.tmpl: http://gerrit.cloudera.org:8080/#/c/20986/9/www/events.tmpl@57 PS9, Line 57: synced Maybe processed would be clearer? -- To view, visit http://gerrit.cloudera.org:8080/20986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e7d4952c7fd04ae89b6751204499bf9dd99f57c Gerrit-Change-Number: 20986 Gerrit-PatchSet: 9 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 14 Mar 2024 08:09:32 +0000 Gerrit-HasComments: Yes
