Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20986 )

Change subject: IMPALA-12782: Show info of the event processing in /events webUI
......................................................................


Patch Set 10:

(2 comments)

PS10 addressed comments and fixes three more issues:
 - currentEvent_ is cleared unintentionally when EP is in non-active state but 
being rescheduled again.
 - eventProcessorErrorMsg_ is not cleared after EP is restarted (by global 
INVALIDATE METADATA)
 - latest event id is not updated if EP is stopped.

http://gerrit.cloudera.org:8080/#/c/20986/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
File 
fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:

http://gerrit.cloudera.org:8080/#/c/20986/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1192
PS3, Line 1192:    * @param currentEventId Current event id on metastore
> I am ok with merging the current state, but I find it pretty confusing. Doi
Based on the offline discussion, let's add these in IMPALA-12912.


http://gerrit.cloudera.org:8080/#/c/20986/9/www/events.tmpl
File www/events.tmpl:

http://gerrit.cloudera.org:8080/#/c/20986/9/www/events.tmpl@57
PS9, Line 57: proces
> Maybe processed would be clearer?
Done



--
To view, visit http://gerrit.cloudera.org:8080/20986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e7d4952c7fd04ae89b6751204499bf9dd99f57c
Gerrit-Change-Number: 20986
Gerrit-PatchSet: 10
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Fri, 15 Mar 2024 10:39:45 +0000
Gerrit-HasComments: Yes

Reply via email to