Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21147 )

Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 
below error is raised                ERROR: Invalid value for query option 
NUM_NODES: <value> is not in range [0, 1]
......................................................................


Patch Set 2:

Thank you for fixing this.
Please also add test in QueryOptions.SetIntOptions. Adding the following line 
in case_set should do it.

{MAKE_OPTIONDEF(num_nodes),    {0, 1}},

https://github.com/apache/impala/blob/691604b1d1f0e5f0dc95fdb4976cf826135e08fb/be/src/service/query-options-test.cc#L247-L248


--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Thu, 14 Mar 2024 16:19:57 +0000
Gerrit-HasComments: No

Reply via email to