Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21147 )
Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM_NODES: <value> is not in range [0, 1] ...................................................................... Patch Set 4: (5 comments) Looks good. Just few style nits to edit. http://gerrit.cloudera.org:8080/#/c/21147/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21147/4//COMMIT_MSG@7 PS4, Line 7: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is raised : ERROR: Invalid value for query option NUM_NODES: <value> is not in range [0, 1] nit: Use short title and separate the title with the rest of commit message with an empty line. I recommend to change it like this: IMPALA-11938: Raise error if NUM_NODES is set to invalid value. If NUM_NODES is set to a value other than 0 or 1 below error is raised: ERROR: Invalid value for query option NUM_NODES: <value> is not in range [0, 1] http://gerrit.cloudera.org:8080/#/c/21147/4/be/src/service/query-options-test.cc File be/src/service/query-options-test.cc: http://gerrit.cloudera.org:8080/#/c/21147/4/be/src/service/query-options-test.cc@273 PS4, Line 273: { nit: align the open curly brace with the one in L266 http://gerrit.cloudera.org:8080/#/c/21147/4/be/src/service/query-options-test.cc@274 PS4, Line 274: }; nit: keep this L274 the same as the original. http://gerrit.cloudera.org:8080/#/c/21147/4/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/21147/4/be/src/service/query-options.cc@246 PS4, Line 246: option, value, 0, 1, &int32_t_val)); > line has trailing whitespace nit: Please remove the trailing whitespace. http://gerrit.cloudera.org:8080/#/c/21147/4/be/src/service/query-options.cc@246 PS4, Line 246: option nit: add 4 spaces indentation before 'option'. -- To view, visit http://gerrit.cloudera.org:8080/21147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812 Gerrit-Change-Number: 21147 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 19 Mar 2024 16:45:15 +0000 Gerrit-HasComments: Yes
