Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10171 )
Change subject: IMPALA-6916: Implement COMMENT ON DATABASE ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/10171/6/common/thrift/JniCatalog.thrift File common/thrift/JniCatalog.thrift: http://gerrit.cloudera.org:8080/#/c/10171/6/common/thrift/JniCatalog.thrift@635 PS6, Line 635: // Name of comment to alter. When this field is not set, the comment will be removed. > Comment what happens if the comment is not set Done http://gerrit.cloudera.org:8080/#/c/10171/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/10171/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3534 PS6, Line 3534: } > There's a subtle race here with the statestore topic update thread that cal Yes, you're right. The new patch set uses the database lock. -- To view, visit http://gerrit.cloudera.org:8080/10171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcf909c18f97073346f6f603538bf921e69fbb00 Gerrit-Change-Number: 10171 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Comment-Date: Wed, 02 May 2018 21:01:52 +0000 Gerrit-HasComments: Yes
