Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10171 )
Change subject: IMPALA-6916: Implement COMMENT ON DATABASE ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/10171/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/10171/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3543 PS8, Line 3543: if (!catalog_.tryLockDb(db)) { Thinking about this again, I don't think we need a DB-level lock. It should be sufficient to hold the versionLock_ to make incrementing the global version and setting it on the Db object atomic. That's the purpose of the versionLock_. Since in this specific case all operations on a Db are of very short duration, it's ok to not add a finer-grained Db lock. -- To view, visit http://gerrit.cloudera.org:8080/10171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcf909c18f97073346f6f603538bf921e69fbb00 Gerrit-Change-Number: 10171 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Comment-Date: Mon, 14 May 2018 21:11:46 +0000 Gerrit-HasComments: Yes
