Hello Quanlong Huang, Riza Suminto, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21151
to look at the new patch set (#4).
Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes
because of wrongly defined test dimensions
......................................................................
IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly
defined test dimensions
test_type_conversions_hive3 silently passes because we are not creating
the test dimenstion for query option orc_shema_resolution correctly. If
we set orc_shema_resolution correctly, i.e. to also exercise the
name-based schema resolution, the test fails. The cause of the failure
is that the ill-typed tables have dummy column names like 'c1', 'c2',
etc. These are completely fine for position-based schema resolution,
but it is not OK for name-based schema resolution.
The test just wants to check error messages related to type errors,
the column names are irrelevant, so we can just use the correct
names.
Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28
---
M
testdata/workloads/functional-query/queries/DataErrorsTest/orc-type-checks.test
M tests/query_test/test_scanners.py
2 files changed, 44 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/21151/4
--
To view, visit http://gerrit.cloudera.org:8080/21151
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28
Gerrit-Change-Number: 21151
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
