Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21151 )
Change subject: IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly defined test dimensions ...................................................................... Patch Set 4: (3 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/21151/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21151/1//COMMIT_MSG@21 PS1, Line 21: f3f3b1427b20a1d2d28 > Maybe one day we want to add this back for IMPALA-12349. It's ok to remove Thanks for pointing me to IMPALA-12349. If we have such plans then I think we shouldn't remove test_type_conversions_hive2 because we might forget to re-add it later. I didn't fix the column names in test_type_conversions_hive2 because I cannot test it, but at least I've left a hint for the future contributor of IMPALA-12349. http://gerrit.cloudera.org:8080/#/c/21151/2/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/21151/2/tests/query_test/test_scanners.py@1717 PS2, Line 1717: # TODO(IMPALA-12349): Rename the columns to use the correct names (see > line has trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/21151/2/tests/query_test/test_scanners.py@1717 PS2, Line 1717: > flake8: W291 trailing whitespace Done -- To view, visit http://gerrit.cloudera.org:8080/21151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28 Gerrit-Change-Number: 21151 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 18 Mar 2024 16:18:20 +0000 Gerrit-HasComments: Yes
