Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/20762 )
Change subject: IMPALA-12540: Query Live Table ...................................................................... Patch Set 41: (3 comments) http://gerrit.cloudera.org:8080/#/c/20762/41/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/20762/41/common/thrift/CatalogObjects.thrift@672 PS41, Line 672: QUERY_LIVE > Well, I do use it to constrain the options in TSystemTable, and it reduces This pattern gives flexibility to add more system tables in the future should the need arise. I also would prefer to keep the actual table name out of the Thrift definitions. http://gerrit.cloudera.org:8080/#/c/20762/41/fe/src/main/java/org/apache/impala/planner/SystemTableScanNode.java File fe/src/main/java/org/apache/impala/planner/SystemTableScanNode.java: http://gerrit.cloudera.org:8080/#/c/20762/41/fe/src/main/java/org/apache/impala/planner/SystemTableScanNode.java@121 PS41, Line 121: 1024L * 1024L > No, honestly no idea what to put here. I guess this is another area we coul The completed queries table cuts off the SQL and PLAN fields based on coordinator startup flags (Default 16mb or 16,777,216 characters). We could do something similar here. Given that the SQL/PLAN/EXEC SUMMARY fields are less important in running queries since they can all be found on the Impala coordinator debug UI, I propose setting a hard, non-configurable limit that is much smaller than 16mb. http://gerrit.cloudera.org:8080/#/c/20762/41/tests/custom_cluster/test_query_live.py File tests/custom_cluster/test_query_live.py: http://gerrit.cloudera.org:8080/#/c/20762/41/tests/custom_cluster/test_query_live.py@24 PS41, Line 24: class TestQueryLive(CustomClusterTestSuite): > Add test querying sys.impala_query_live over cluster with multiple coordina Since these tests do not change the size of the test clusters, they will all run against a 3-node cluster. It would be good though to submit queries to each coordinator and then verify that all three queries appear in the sys.impala_query_live table. -- To view, visit http://gerrit.cloudera.org:8080/20762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2f9a449f0e5502078931e7f1c5df6e0b762c743 Gerrit-Change-Number: 20762 Gerrit-PatchSet: 41 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 20 Mar 2024 18:44:04 +0000 Gerrit-HasComments: Yes
