Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20762 )
Change subject: IMPALA-12540: Query Live Table ...................................................................... Patch Set 41: (19 comments) All looks good, I have a few nits and questions http://gerrit.cloudera.org:8080/#/c/20762/41/be/src/exec/system-table-scanner.cc File be/src/exec/system-table-scanner.cc: http://gerrit.cloudera.org:8080/#/c/20762/41/be/src/exec/system-table-scanner.cc@26 PS41, Line 26: #include "runtime/decimal-value.h" unused http://gerrit.cloudera.org:8080/#/c/20762/41/be/src/exec/system-table-scanner.cc@27 PS41, Line 27: #include "runtime/decimal-value.inline.h" unused http://gerrit.cloudera.org:8080/#/c/20762/41/be/src/exec/system-table-scanner.cc@71 PS41, Line 71: MaterializeNextRow WriteStringSlot? http://gerrit.cloudera.org:8080/#/c/20762/41/be/src/exec/system-table-scanner.cc@157 PS41, Line 157: for (int i = 0; i < tuple_desc->slots().size(); ++i) { Nit: for (auto slot_desc : tuple_desc->slots()) http://gerrit.cloudera.org:8080/#/c/20762/41/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/20762/41/common/thrift/CatalogObjects.thrift@65 PS41, Line 65: SYSTEM_TABLE = 8 Add a brief comment http://gerrit.cloudera.org:8080/#/c/20762/41/common/thrift/CatalogObjects.thrift@672 PS41, Line 672: QUERY_LIVE > Well, I do use it to constrain the options in TSystemTable, and it reduces Add a brief comment http://gerrit.cloudera.org:8080/#/c/20762/41/common/thrift/SystemTables.thrift File common/thrift/SystemTables.thrift: http://gerrit.cloudera.org:8080/#/c/20762/41/common/thrift/SystemTables.thrift@21 PS41, Line 21: enum TQueryColumn { Add a note that this must be kept in sync with workload-management-fields.cc (IIUIC) (and possibly a back-link from there to here) http://gerrit.cloudera.org:8080/#/c/20762/41/fe/src/main/java/org/apache/impala/catalog/Db.java File fe/src/main/java/org/apache/impala/catalog/Db.java: http://gerrit.cloudera.org:8080/#/c/20762/41/fe/src/main/java/org/apache/impala/catalog/Db.java@134 PS41, Line 134: "sys" Nit: should we have a constant for this? http://gerrit.cloudera.org:8080/#/c/20762/41/fe/src/main/java/org/apache/impala/catalog/SystemTable.java File fe/src/main/java/org/apache/impala/catalog/SystemTable.java: http://gerrit.cloudera.org:8080/#/c/20762/41/fe/src/main/java/org/apache/impala/catalog/SystemTable.java@52 PS41, Line 52: private static Map<String, TSystemTableName> SYSTEM_TABLE_NAME_MAP = could be final? http://gerrit.cloudera.org:8080/#/c/20762/41/fe/src/main/java/org/apache/impala/catalog/SystemTable.java@184 PS41, Line 184: String, String unnecessary? http://gerrit.cloudera.org:8080/#/c/20762/41/fe/src/main/java/org/apache/impala/catalog/SystemTable.java@186 PS41, Line 186: FieldSchema unnecessary? http://gerrit.cloudera.org:8080/#/c/20762/41/fe/src/main/java/org/apache/impala/planner/SystemTableScanNode.java File fe/src/main/java/org/apache/impala/planner/SystemTableScanNode.java: http://gerrit.cloudera.org:8080/#/c/20762/41/fe/src/main/java/org/apache/impala/planner/SystemTableScanNode.java@21 PS41, Line 21: import java.util.Map; unused http://gerrit.cloudera.org:8080/#/c/20762/41/fe/src/main/java/org/apache/impala/planner/SystemTableScanNode.java@23 PS41, Line 23: import org.slf4j.Logger; unused http://gerrit.cloudera.org:8080/#/c/20762/41/fe/src/main/java/org/apache/impala/planner/SystemTableScanNode.java@24 PS41, Line 24: import org.slf4j.LoggerFactory; unused http://gerrit.cloudera.org:8080/#/c/20762/41/fe/src/main/java/org/apache/impala/planner/SystemTableScanNode.java@43 PS41, Line 43: import org.apache.impala.thrift.TSystemTableName; unused http://gerrit.cloudera.org:8080/#/c/20762/41/fe/src/main/java/org/apache/impala/planner/SystemTableScanNode.java@46 PS41, Line 46: import com.google.common.collect.ImmutableMap; unused http://gerrit.cloudera.org:8080/#/c/20762/41/tests/custom_cluster/test_query_live.py File tests/custom_cluster/test_query_live.py: http://gerrit.cloudera.org:8080/#/c/20762/41/tests/custom_cluster/test_query_live.py@30 PS41, Line 30: vector unused http://gerrit.cloudera.org:8080/#/c/20762/41/tests/custom_cluster/test_query_live.py@36 PS41, Line 36: assert_query('sys.impala_query_live', self.client, 'test_query_live_1', Is there any race where the data about the query can get written before we look at impala_query_live? http://gerrit.cloudera.org:8080/#/c/20762/41/tests/custom_cluster/test_query_live.py@64 PS41, Line 64: vector unused -- To view, visit http://gerrit.cloudera.org:8080/20762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2f9a449f0e5502078931e7f1c5df6e0b762c743 Gerrit-Change-Number: 20762 Gerrit-PatchSet: 41 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 20 Mar 2024 20:17:18 +0000 Gerrit-HasComments: Yes
