Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21174 )
Change subject: IMPALA-4545: Simplify test dimension in test_decimal_casting.py ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21174/1/tests/query_test/test_decimal_casting.py File tests/query_test/test_decimal_casting.py: http://gerrit.cloudera.org:8080/#/c/21174/1/tests/query_test/test_decimal_casting.py@54 PS1, Line 54: Core only deals with precision 6, 16, 26 Not familiar with the "pairwise" mode, is it the same as the core now? http://gerrit.cloudera.org:8080/#/c/21174/1/tests/query_test/test_decimal_casting.py@109 PS1, Line 109: # precision, scale = vector.get_value('decimal_type') This line can be removed? -- To view, visit http://gerrit.cloudera.org:8080/21174 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe269e08a955097ad9e924d5d64b42438ad15be2 Gerrit-Change-Number: 21174 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Thu, 21 Mar 2024 01:47:50 +0000 Gerrit-HasComments: Yes
