Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21174 )
Change subject: IMPALA-4545: Simplify test dimension in test_decimal_casting.py ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21174/1/tests/query_test/test_decimal_casting.py File tests/query_test/test_decimal_casting.py: http://gerrit.cloudera.org:8080/#/c/21174/1/tests/query_test/test_decimal_casting.py@54 PS1, Line 54: Core/pairwise only deals with precision > Yes, core is permuted the same as pairwise now. Can you also mention it in the commit message? Because the testing behavior for "pairwise" is changed. -- To view, visit http://gerrit.cloudera.org:8080/21174 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe269e08a955097ad9e924d5d64b42438ad15be2 Gerrit-Change-Number: 21174 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 21 Mar 2024 15:47:54 +0000 Gerrit-HasComments: Yes
