Andrew Sherman has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20762 )

Change subject: IMPALA-12540: Query Live Table
......................................................................


Patch Set 44: Code-Review+1

(3 comments)

http://gerrit.cloudera.org:8080/#/c/20762/44//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20762/44//COMMIT_MSG@9
PS44, Line 9: are
Nit: "is infrastructure for"


http://gerrit.cloudera.org:8080/#/c/20762/44//COMMIT_MSG@10
PS44, Line 10: to Impala state. Adds the 'impala_query_live' to the database 
'sys',
Nit: I think you're saying something like: "Adds the impala_query_live table to 
the
'sys' database which already contains the impala_query_log table.


http://gerrit.cloudera.org:8080/#/c/20762/41/tests/custom_cluster/test_query_live.py
File tests/custom_cluster/test_query_live.py:

http://gerrit.cloudera.org:8080/#/c/20762/41/tests/custom_cluster/test_query_live.py@36
PS41, Line 36:         fetch_profile_after_close=True)
> It includes currently running queries - which will be true about itself - a
Thanks for the explanations



--
To view, visit http://gerrit.cloudera.org:8080/20762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2f9a449f0e5502078931e7f1c5df6e0b762c743
Gerrit-Change-Number: 20762
Gerrit-PatchSet: 44
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Thu, 21 Mar 2024 17:47:04 +0000
Gerrit-HasComments: Yes

Reply via email to