Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20762 )
Change subject: IMPALA-12540: Query Live Table ...................................................................... Patch Set 43: (3 comments) http://gerrit.cloudera.org:8080/#/c/20762/41/be/src/exec/system-table-scanner.cc File be/src/exec/system-table-scanner.cc: http://gerrit.cloudera.org:8080/#/c/20762/41/be/src/exec/system-table-scanner.cc@214 PS41, Line 214: case TQueryColumn::QUERY_OPTS_CONFIG: > I wonder if this should represent something like "duration" (now() - start_ I'd be OK showing -1 here. Should END_TIME_UTC column be added as well? http://gerrit.cloudera.org:8080/#/c/20762/43/testdata/workloads/functional-planner/queries/PlannerTest/impala-query-live.test File testdata/workloads/functional-planner/queries/PlannerTest/impala-query-live.test: http://gerrit.cloudera.org:8080/#/c/20762/43/testdata/workloads/functional-planner/queries/PlannerTest/impala-query-live.test@14 PS43, Line 14: # Error trying to create new sys.impala_query_live : create table sys.impala_query_live (i int) Please add test to show that insert/delete/update over impala_query_live will throw exception. http://gerrit.cloudera.org:8080/#/c/20762/43/tests/custom_cluster/test_query_live.py File tests/custom_cluster/test_query_live.py: http://gerrit.cloudera.org:8080/#/c/20762/43/tests/custom_cluster/test_query_live.py@49 PS43, Line 49: # query filtering Please add tests with group by and count. -- To view, visit http://gerrit.cloudera.org:8080/20762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2f9a449f0e5502078931e7f1c5df6e0b762c743 Gerrit-Change-Number: 20762 Gerrit-PatchSet: 43 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 21 Mar 2024 17:08:29 +0000 Gerrit-HasComments: Yes
