Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21174 )
Change subject: IMPALA-4545: Simplify test dimension in test_decimal_casting.py ...................................................................... IMPALA-4545: Simplify test dimension in test_decimal_casting.py This patch splits precision and scale as independent dimensions and then constrains them to yield a valid decimal type. With this split, core exploration will have the same test dimension as pairwise exploration, while exhaustive exploration still permutes all possible decimal types. Also did minor refactoring to reduce test skipping and pass flake8. After this patch, core exploration has 214 test items and exhaustive exploration has 12312 test items. Before, they were 408 and 12464 respectively. Testing: - Pass test_decimal_casting.py in core and exhaustive exploration. Change-Id: Ibe269e08a955097ad9e924d5d64b42438ad15be2 Reviewed-on: http://gerrit.cloudera.org:8080/21174 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M tests/query_test/test_decimal_casting.py 1 file changed, 48 insertions(+), 29 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21174 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ibe269e08a955097ad9e924d5d64b42438ad15be2 Gerrit-Change-Number: 21174 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
