Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20762 )
Change subject: IMPALA-12540: Query Live Table ...................................................................... Patch Set 48: (4 comments) http://gerrit.cloudera.org:8080/#/c/20762/47/be/src/exec/system-table-scanner.cc File be/src/exec/system-table-scanner.cc: http://gerrit.cloudera.org:8080/#/c/20762/47/be/src/exec/system-table-scanner.cc@209 PS47, Line 209: const int64_t end_t > Nit: if pushing another patch, please mark const. If not pushing another p I wish C++ had a nice syntax for value initialization as const. It gets verbose if we put it everywhere. Why did you single these out in particular? http://gerrit.cloudera.org:8080/#/c/20762/47/be/src/exec/system-table-scanner.cc@210 PS47, Line 210: record.end_time > Nit: if pushing another patch, please mark const. If not pushing another p Done http://gerrit.cloudera.org:8080/#/c/20762/47/be/src/service/fe-support.cc File be/src/service/fe-support.cc: http://gerrit.cloudera.org:8080/#/c/20762/47/be/src/service/fe-support.cc@668 PS47, Line 668: > Wrap condition with LIKELY since server should only be nullptr when running Done http://gerrit.cloudera.org:8080/#/c/20762/47/fe/src/main/java/org/apache/impala/catalog/Db.java File fe/src/main/java/org/apache/impala/catalog/Db.java: http://gerrit.cloudera.org:8080/#/c/20762/47/fe/src/main/java/org/apache/impala/catalog/Db.java@137 PS47, Line 137: is > Nit: was? If this was a log message, that would make sense. As an explanation to someone looking at the code, I think the current tense makes more sense. "was" would imply that tests used to do that, which doesn't make a lot of sense. -- To view, visit http://gerrit.cloudera.org:8080/20762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2f9a449f0e5502078931e7f1c5df6e0b762c743 Gerrit-Change-Number: 20762 Gerrit-PatchSet: 48 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 25 Mar 2024 17:45:08 +0000 Gerrit-HasComments: Yes
