Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20762 )
Change subject: IMPALA-12540: Query Live Table ...................................................................... Patch Set 49: Code-Review+1 (3 comments) Other than flake8 warnings, ps49 looks good to me. http://gerrit.cloudera.org:8080/#/c/20762/49/tests/custom_cluster/test_query_live.py File tests/custom_cluster/test_query_live.py: http://gerrit.cloudera.org:8080/#/c/20762/49/tests/custom_cluster/test_query_live.py@253 PS49, Line 253: \ > flake8: W605 invalid escape sequence '\(' Prepend the pattern string with 'r' usually help. r'Per Host Number .... http://gerrit.cloudera.org:8080/#/c/20762/49/tests/custom_cluster/test_query_live.py@268 PS49, Line 268: result = self.client.execute('select straight_join count(*) from {}.users, ' > Needing straight_join here is kind of awkward, but not sure what to do abou The join order and data partitioning might be reliant on stats and cardinality. Run compute stats over users table might help, but I rather use straight_join like this since it is simpler. http://gerrit.cloudera.org:8080/#/c/20762/49/tests/custom_cluster/test_query_live.py@282 PS49, Line 282: \ > flake8: W605 invalid escape sequence '\(' Prepend the pattern string with 'r' usually help. r'Per Host Number .... -- To view, visit http://gerrit.cloudera.org:8080/20762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2f9a449f0e5502078931e7f1c5df6e0b762c743 Gerrit-Change-Number: 20762 Gerrit-PatchSet: 49 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 26 Mar 2024 01:30:18 +0000 Gerrit-HasComments: Yes
