Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/20762 )
Change subject: IMPALA-12540: Query Live Table ...................................................................... Patch Set 50: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/20762/47/be/src/exec/system-table-scanner.cc File be/src/exec/system-table-scanner.cc: http://gerrit.cloudera.org:8080/#/c/20762/47/be/src/exec/system-table-scanner.cc@209 PS47, Line 209: const int64_t end_t > I wish C++ had a nice syntax for value initialization as const. It gets ver I didn't actually see any another places where const would have worked. http://gerrit.cloudera.org:8080/#/c/20762/50/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/20762/50/be/src/scheduling/scheduler.cc@391 PS50, Line 391: might changed Nit: This doesn't quite make sense, but I'm not sure if the message should be "membership might have changed" or "membership changed". http://gerrit.cloudera.org:8080/#/c/20762/47/fe/src/main/java/org/apache/impala/catalog/Db.java File fe/src/main/java/org/apache/impala/catalog/Db.java: http://gerrit.cloudera.org:8080/#/c/20762/47/fe/src/main/java/org/apache/impala/catalog/Db.java@137 PS47, Line 137: is > If this was a log message, that would make sense. As an explanation to some Sounds good! -- To view, visit http://gerrit.cloudera.org:8080/20762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2f9a449f0e5502078931e7f1c5df6e0b762c743 Gerrit-Change-Number: 20762 Gerrit-PatchSet: 50 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 26 Mar 2024 18:32:58 +0000 Gerrit-HasComments: Yes
