Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20921 )
Change subject: IMPALA-12362: (part-1/4) Refactor service management scripts. ...................................................................... Patch Set 14: (2 comments) It looks almost good to me. http://gerrit.cloudera.org:8080/#/c/20921/14/package/bin/impala.sh File package/bin/impala.sh: http://gerrit.cloudera.org:8080/#/c/20921/14/package/bin/impala.sh@233 PS14, Line 233: echo " -c: same as health command's option." : echo " -p: same as health command's option." nit: It seems that explaining it directly won't be too lengthy, and perhaps not quoting the 'health' would be more intuitive. http://gerrit.cloudera.org:8080/#/c/20921/14/package/bin/impala.sh@238 PS14, Line 238: -f: sigal kill -9 to process." It seems we have not yet supported the -f option. -- To view, visit http://gerrit.cloudera.org:8080/20921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f4dcad9cfa12d351d562e7ef8c0a8957d3ca147 Gerrit-Change-Number: 20921 Gerrit-PatchSet: 14 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Wed, 27 Mar 2024 10:26:30 +0000 Gerrit-HasComments: Yes
