Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20921 )
Change subject: IMPALA-12362: (part-1/4) Refactor service management scripts. ...................................................................... Patch Set 15: (2 comments) > Patch Set 14: > > (2 comments) > > It looks almost good to me. http://gerrit.cloudera.org:8080/#/c/20921/14/package/bin/impala.sh File package/bin/impala.sh: http://gerrit.cloudera.org:8080/#/c/20921/14/package/bin/impala.sh@233 PS14, Line 233: echo " -c: maximum count of checks, defaults to 20." : echo " -p: seconds of period between checks, > nit: It seems that explaining it directly won't be too lengthy, and perhaps Done http://gerrit.cloudera.org:8080/#/c/20921/14/package/bin/impala.sh@238 PS14, Line 238: -c: maximum count of checks, d > It seems we have not yet supported the -f option. Done -- To view, visit http://gerrit.cloudera.org:8080/20921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f4dcad9cfa12d351d562e7ef8c0a8957d3ca147 Gerrit-Change-Number: 20921 Gerrit-PatchSet: 15 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Fri, 29 Mar 2024 00:16:22 +0000 Gerrit-HasComments: Yes
