Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20946 )
Change subject: IMPALA-12749: Add query option 'CROSS_JOIN_ENABLED'. ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/20946/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20946/4//COMMIT_MSG@7 PS4, Line 7: CROSS_JOIN_ENABLED nit: 'DISABLE_CROSS_JOIN' might be more in line with the style of other similar feature query options. http://gerrit.cloudera.org:8080/#/c/20946/4//COMMIT_MSG@9 PS4, Line 9: Add a query option 'CROSS_JOIN_ENABLED' to control whether to allow : cross join or not, the default value is true. Could you further explain why we need this query option and in what scenarios it might be used? http://gerrit.cloudera.org:8080/#/c/20946/4/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/20946/4/be/src/service/query-options.h@53 PS4, Line 53: \ Need to align the '\' http://gerrit.cloudera.org:8080/#/c/20946/4/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/20946/4/common/thrift/Query.thrift@700 PS4, Line 700: 175: optional bool cross_join_enabled = true; Need to add the comment http://gerrit.cloudera.org:8080/#/c/20946/4/fe/src/main/java/org/apache/impala/planner/NestedLoopJoinNode.java File fe/src/main/java/org/apache/impala/planner/NestedLoopJoinNode.java: http://gerrit.cloudera.org:8080/#/c/20946/4/fe/src/main/java/org/apache/impala/planner/NestedLoopJoinNode.java@81 PS4, Line 81: Cross Join is disabled! It's better to specify in detail why it was disabled (for example, being disabled by setting CROSS_JOIN_ENABLED=false) or how to re-enable it. http://gerrit.cloudera.org:8080/#/c/20946/4/tests/query_test/test_join_queries.py File tests/query_test/test_join_queries.py: http://gerrit.cloudera.org:8080/#/c/20946/4/tests/query_test/test_join_queries.py@116 PS4, Line 116: test_cross_joins 'test_disable_cross_join' seems more appropriate. -- To view, visit http://gerrit.cloudera.org:8080/20946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d973118a6d1e433475161924bd0eeafde21bb37 Gerrit-Change-Number: 20946 Gerrit-PatchSet: 4 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Mon, 01 Apr 2024 03:11:20 +0000 Gerrit-HasComments: Yes
