Hello Zihao Ye, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20946

to look at the new patch set (#5).

Change subject: IMPALA-12749: Add query option 'DISABLE_CROSS_JOIN'.
......................................................................

IMPALA-12749: Add query option 'DISABLE_CROSS_JOIN'.

It is well known that the cross join has poor performance, and a SQL
which has cross join can even block the execution of other SQL
sometimes. For this reason Hive add a configuration "hive.strict.
checks.cartesian.product" to control whether allow cross join or not.
This patch add a similar query option 'DISABLE_CROSS_JOIN', which
defaults to false.

Testing:
 - Add an EE test.

Change-Id: I2d973118a6d1e433475161924bd0eeafde21bb37
---
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/ImpalaService.thrift
M common/thrift/Query.thrift
M fe/src/main/java/org/apache/impala/planner/NestedLoopJoinNode.java
A testdata/workloads/functional-query/queries/QueryTest/cross-joins.test
M tests/query_test/test_join_queries.py
7 files changed, 32 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/20946/5
--
To view, visit http://gerrit.cloudera.org:8080/20946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d973118a6d1e433475161924bd0eeafde21bb37
Gerrit-Change-Number: 20946
Gerrit-PatchSet: 5
Gerrit-Owner: Xiang Yang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Xiang Yang <[email protected]>
Gerrit-Reviewer: Zihao Ye <[email protected]>

Reply via email to