Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/21171 )
Change subject: IMPALA-12905: Disk-based tuple caching ...................................................................... Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-cache-node.h File be/src/exec/tuple-cache-node.h: http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-cache-node.h@27 PS6, Line 27: class TupleFileReader; Are these forward declarations needed? I though the unique_ptr members below need the classes declared? http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-cache-node.cc File be/src/exec/tuple-cache-node.cc: http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-cache-node.cc@61 PS6, Line 61: SCOPED_TIMER(runtime_profile_->total_time_counter()); runtime_profile() used above. http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-cache-node.cc@142 PS6, Line 142: } else if (writer_->BytesWritten() > tuple_cache_mgr->MaxSize()) { Should check the size and not write if it is over. http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-file-reader.h File be/src/exec/tuple-file-reader.h: http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-file-reader.h@30 PS6, Line 30: class MemTracker; Is this forward declaration needed? http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-file-reader.cc File be/src/exec/tuple-file-reader.cc: http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-file-reader.cc@77 PS6, Line 77: reader_.read(reinterpret_cast<char*>(&tuple_data_len), sizeof(tuple_data_len)); Check status after reads using if(!reader_) like below. http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-file-reader.cc@79 PS6, Line 79: DCHECK_GE(tuple_data_len, 0); These may not be initialized if read fails. http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-file-writer.cc File be/src/exec/tuple-file-writer.cc: http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-file-writer.cc@89 PS6, Line 89: if (!writer_) { Is it sufficient to just check the stream status here or can a transient error leave the write file invalid? -- To view, visit http://gerrit.cloudera.org:8080/21171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13a65c4c0559cad3559d5f714a074dd06e9cc9bf Gerrit-Change-Number: 21171 Gerrit-PatchSet: 6 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Tue, 02 Apr 2024 01:00:04 +0000 Gerrit-HasComments: Yes
