Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21171 )
Change subject: IMPALA-12905: Disk-based tuple caching ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-cache-node.h File be/src/exec/tuple-cache-node.h: http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-cache-node.h@27 PS6, Line 27: class TupleFileReader; > Are these forward declarations needed? I though the unique_ptr members belo I guess I'm not sure why this works either. The compiler doesn't complain, but we don't declare a destructor (which is where https://en.cppreference.com/w/cpp/memory/unique_ptr notes that the class needs to be complete). Maybe it just needs to be complete where an instance of TupleCacheNode is instantiated? http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-file-writer.cc File be/src/exec/tuple-file-writer.cc: http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-file-writer.cc@89 PS6, Line 89: if (!writer_) { > Is it sufficient to just check the stream status here or can a transient er I don't know of any particular issue with multiple failed writes. -- To view, visit http://gerrit.cloudera.org:8080/21171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13a65c4c0559cad3559d5f714a074dd06e9cc9bf Gerrit-Change-Number: 21171 Gerrit-PatchSet: 6 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Tue, 02 Apr 2024 15:35:26 +0000 Gerrit-HasComments: Yes
