Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20946 )
Change subject: IMPALA-12749: Add query option 'DISABLE_CROSS_JOIN'. ...................................................................... Patch Set 5: (7 comments) Hi zihao, Thanks for your careful review! http://gerrit.cloudera.org:8080/#/c/20946/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20946/4//COMMIT_MSG@7 PS4, Line 7: DISABLE_CROSS_JOIN > nit: 'DISABLE_CROSS_JOIN' might be more in line with the style of other sim I think the 'supression-type' naming is counterintuitive, but either way is ok. http://gerrit.cloudera.org:8080/#/c/20946/4//COMMIT_MSG@9 PS4, Line 9: It is well known that the cross join has poor performance, and a SQL : which has cross join can even block the execu > Could you further explain why we need this query option and in what scenari Done http://gerrit.cloudera.org:8080/#/c/20946/4/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/20946/4/be/src/service/query-options.h@53 PS4, Line 53: > Need to align the '\' Done http://gerrit.cloudera.org:8080/#/c/20946/4/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/20946/4/common/thrift/Query.thrift@700 PS4, Line 700: // See comment in ImpalaService.thrift > Need to add the comment Done http://gerrit.cloudera.org:8080/#/c/20946/4/fe/src/main/java/org/apache/impala/planner/NestedLoopJoinNode.java File fe/src/main/java/org/apache/impala/planner/NestedLoopJoinNode.java: http://gerrit.cloudera.org:8080/#/c/20946/4/fe/src/main/java/org/apache/impala/planner/NestedLoopJoinNode.java@81 PS4, Line 81: Cross Join is disabled > It's better to specify in detail why it was disabled (for example, being di Done http://gerrit.cloudera.org:8080/#/c/20946/5/testdata/workloads/functional-query/queries/QueryTest/cross-joins.test File testdata/workloads/functional-query/queries/QueryTest/cross-joins.test: http://gerrit.cloudera.org:8080/#/c/20946/5/testdata/workloads/functional-query/queries/QueryTest/cross-joins.test@7 PS5, Line 7: ==== I accidentally deleted part of it, I'll add it later. http://gerrit.cloudera.org:8080/#/c/20946/4/tests/query_test/test_join_queries.py File tests/query_test/test_join_queries.py: http://gerrit.cloudera.org:8080/#/c/20946/4/tests/query_test/test_join_queries.py@116 PS4, Line 116: test_cross_joins > 'test_disable_cross_join' seems more appropriate. I keep it unchanged, for we can add more 'cross-join' related test in the future, but not only 'disable-cross-join' testcase. -- To view, visit http://gerrit.cloudera.org:8080/20946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d973118a6d1e433475161924bd0eeafde21bb37 Gerrit-Change-Number: 20946 Gerrit-PatchSet: 5 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Tue, 02 Apr 2024 02:04:14 +0000 Gerrit-HasComments: Yes
