Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21230 )
Change subject: IMPALA-12965: Add debug query option RUNTIME_FILTER_IDS_TO_SKIP ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/21230/1/be/src/service/query-options-test.cc File be/src/service/query-options-test.cc: http://gerrit.cloudera.org:8080/#/c/21230/1/be/src/service/query-options-test.cc@734 PS1, Line 734: EXPECT_TRUE(SetQueryOption(KEY, "0,,1", &options, nullptr).ok()); > more cases, like "0, 1", "0, 1, , 2" Done http://gerrit.cloudera.org:8080/#/c/21230/1/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/21230/1/be/src/service/query-options.cc@1299 PS1, Line 1299: : end++; > if (options.at(end) == ',' && double_quote_ct == 0 && begin == end), need t Make sense. Done. http://gerrit.cloudera.org:8080/#/c/21230/1/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/21230/1/common/thrift/ImpalaService.thrift@928 PS1, Line 928: List of runtime filter id to skip > nit: could you give format of id list with sample? Double quoted numbers se Done -- To view, visit http://gerrit.cloudera.org:8080/21230 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I897e37685dd1ec279989b55560ec7616a00d2280 Gerrit-Change-Number: 21230 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 03 Apr 2024 19:28:12 +0000 Gerrit-HasComments: Yes
