Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21230 )
Change subject: IMPALA-12965: Add debug query option RUNTIME_FILTER_IDS_TO_SKIP ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21230/2/be/src/service/query-options-test.cc File be/src/service/query-options-test.cc: http://gerrit.cloudera.org:8080/#/c/21230/2/be/src/service/query-options-test.cc@739 PS2, Line 739: 0, 1, , 2 nit: just curious why "0,,1" is accept, but "0, 1, , 2" is rejected. Maybe we should trim the spaces after splitting the string and skip empty string. http://gerrit.cloudera.org:8080/#/c/21230/2/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/21230/2/be/src/service/query-options.cc@1257 PS2, Line 1257: t trim the spaces and skip empty string? -- To view, visit http://gerrit.cloudera.org:8080/21230 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I897e37685dd1ec279989b55560ec7616a00d2280 Gerrit-Change-Number: 21230 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 03 Apr 2024 21:25:49 +0000 Gerrit-HasComments: Yes
