Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21234 )
Change subject: IMPALA-12969: Release JNI array if DeserializeThriftMsg failed ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/21234/1/be/src/rpc/jni-thrift-util.h File be/src/rpc/jni-thrift-util.h: http://gerrit.cloudera.org:8080/#/c/21234/1/be/src/rpc/jni-thrift-util.h@61 PS1, Line 61: Status status = DeserializeThriftMsg( We could use something like JniUtil::JniUtfCharGuard for arrays as well. I understand that it is urgent to correct this error so it can be done in another commit. -- To view, visit http://gerrit.cloudera.org:8080/21234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2c0335b12e9289ae851d0ec050765951a8ca6c7 Gerrit-Change-Number: 21234 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Wed, 03 Apr 2024 21:39:20 +0000 Gerrit-HasComments: Yes
