Csaba Ringhofer has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/21234 )

Change subject: IMPALA-12969: Release JNI array if DeserializeThriftMsg failed
......................................................................

IMPALA-12969: Release JNI array if DeserializeThriftMsg failed

Before this patch ReleaseByteArrayElements was not called in case
the deserialization failed (e.g. by hitting Thrift's MaxMessageSize).
This could potentially cause JVM/native heap leak, depending on how
the JVM handled the array allocation.

Change-Id: Id2c0335b12e9289ae851d0ec050765951a8ca6c7
Reviewed-on: http://gerrit.cloudera.org:8080/21234
Reviewed-by: Michael Smith <[email protected]>
Reviewed-by: Daniel Becker <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
M be/src/rpc/jni-thrift-util.h
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Michael Smith: Looks good to me, but someone else must approve
  Daniel Becker: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/21234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2c0335b12e9289ae851d0ec050765951a8ca6c7
Gerrit-Change-Number: 21234
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>

Reply via email to