Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 )
Change subject: [TEST][WIP]IMPALA-11499: Refactor UrlEncode function to handle special characters ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/21131/4/be/src/util/coding-util.cc File be/src/util/coding-util.cc: http://gerrit.cloudera.org:8080/#/c/21131/4/be/src/util/coding-util.cc@74 PS4, Line 74: static inline void UrlEncode(const char* in, int in_len, std::string* out, bool hive_compat) { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21131/4/be/src/util/coding-util.cc@81 PS4, Line 81: // a) We are in Hive-compat mode and the character should be escaped according to specialCharacterMap line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/21131/4/be/src/util/coding-util.cc@82 PS4, Line 82: // b) We are not in Hive-compat mode and the character is not alphanumeric or one of the commonly excluded characters line too long (121 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c4aba5d811dfcec809583d0c16fcbc0ca730fb Gerrit-Change-Number: 21131 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Thu, 04 Apr 2024 10:14:15 +0000 Gerrit-HasComments: Yes
