Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 )
Change subject: [TEST][WIP]IMPALA-11499: Refactor UrlEncode function to handle special characters ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/21131/4/be/src/util/coding-util.cc File be/src/util/coding-util.cc: http://gerrit.cloudera.org:8080/#/c/21131/4/be/src/util/coding-util.cc@83 PS4, Line 83: if ((hive_compat && specialCharacterMap.find(ch) != specialCharacterMap.end()) || Repeated lookup on specialCharacterMap. You could do auto it = specialCharacterMap.find(ch); outside the if-clause and reuse it. http://gerrit.cloudera.org:8080/#/c/21131/4/be/src/util/coding-util.cc@117 PS4, Line 117: Avoid unnecessary whitespace change. -- To view, visit http://gerrit.cloudera.org:8080/21131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c4aba5d811dfcec809583d0c16fcbc0ca730fb Gerrit-Change-Number: 21131 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zihao Ye <eyiz...@163.com> Gerrit-Comment-Date: Wed, 17 Apr 2024 17:48:54 +0000 Gerrit-HasComments: Yes
