Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21168 )
Change subject: IMPALA-12920: Support ai_generate_text built-in function for OpenAI's chat completion API ...................................................................... Patch Set 8: (8 comments) http://gerrit.cloudera.org:8080/#/c/21168/6/be/src/exprs/ai-functions-ir.cc File be/src/exprs/ai-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/21168/6/be/src/exprs/ai-functions-ir.cc@101 PS6, Line 101: // Check if the "choices" array exists and is not empty > Makes sense. Added a check for n == 1. Ack http://gerrit.cloudera.org:8080/#/c/21168/6/be/src/exprs/ai-functions-ir.cc@128 PS6, Line 128: json.Accept(writer); > Updated code to use string_view also templatized to minimize branches for t Done http://gerrit.cloudera.org:8080/#/c/21168/8/be/src/exprs/ai-functions-ir.cc File be/src/exprs/ai-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/21168/8/be/src/exprs/ai-functions-ir.cc@217 PS8, Line 217: << ": 'n' must be of integer type or have value 1"; "integer type and have value 1". Logic above might be clearer as !(m.value.IsInt() && m.value.GetInt() == 1) http://gerrit.cloudera.org:8080/#/c/21168/6/be/src/exprs/scalar-expr-evaluator.cc File be/src/exprs/scalar-expr-evaluator.cc: http://gerrit.cloudera.org:8080/#/c/21168/6/be/src/exprs/scalar-expr-evaluator.cc@453 PS6, Line 453: AiFunctions::AiGenerateTextInternal<true>(nullptr, StringVal::null(), StringVal::null(), > Done. Ack http://gerrit.cloudera.org:8080/#/c/21168/6/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/21168/6/be/src/runtime/exec-env.cc@a213 PS6, Line 213: > nit: unnecessary whitespace change; spacing here is pretty arbitrary Actually I think it's pretty standard for us to put an empty line after declaring a namespace to make it stand out. http://gerrit.cloudera.org:8080/#/c/21168/6/be/src/runtime/exec-env.cc@528 PS6, Line 528: return Status::OK(); > Yeah for the case where the secret-key changes there is an alternative to p Ack http://gerrit.cloudera.org:8080/#/c/21168/6/be/src/runtime/exec-env.cc@535 PS6, Line 535: TGetHadoopConfigRequest config_request; > The rationale is that there is an alternative where user could pass the cor Done. Usually makes sense to fail startup for incorrectly formatted config options. http://gerrit.cloudera.org:8080/#/c/21168/6/be/src/udf/udf.h File be/src/udf/udf.h: http://gerrit.cloudera.org:8080/#/c/21168/6/be/src/udf/udf.h@a742 PS6, Line 742: > Removed unintentional whitespace change. Done -- To view, visit http://gerrit.cloudera.org:8080/21168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4446957f6030bab1f985fdd69185c3da07d7c4b Gerrit-Change-Number: 21168 Gerrit-PatchSet: 8 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 08 Apr 2024 18:12:25 +0000 Gerrit-HasComments: Yes
