Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21168 )
Change subject: IMPALA-12920: Support ai_generate_text built-in function for OpenAI's chat completion API ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/21168/8/be/src/exprs/ai-functions-ir.cc File be/src/exprs/ai-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/21168/8/be/src/exprs/ai-functions-ir.cc@217 PS8, Line 217: << ": 'n' must be of integer type and have value 1"; > "integer type and have value 1". Logic above might be clearer as Done http://gerrit.cloudera.org:8080/#/c/21168/8/be/src/exprs/ai-functions-ir.cc@217 PS8, Line 217: an > and ? Done http://gerrit.cloudera.org:8080/#/c/21168/6/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/21168/6/be/src/runtime/exec-env.cc@a213 PS6, Line 213: > Actually I think it's pretty standard for us to put an empty line after dec Fixed whitespace after namespace declaration in latest patch. http://gerrit.cloudera.org:8080/#/c/21168/8/fe/src/main/java/org/apache/impala/service/JniFrontend.java File fe/src/main/java/org/apache/impala/service/JniFrontend.java: http://gerrit.cloudera.org:8080/#/c/21168/8/fe/src/main/java/org/apache/impala/service/JniFrontend.java@138 PS8, Line 138: invalid key > nit: write key value of invalid key in error message Done -- To view, visit http://gerrit.cloudera.org:8080/21168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4446957f6030bab1f985fdd69185c3da07d7c4b Gerrit-Change-Number: 21168 Gerrit-PatchSet: 9 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 08 Apr 2024 20:01:56 +0000 Gerrit-HasComments: Yes
