Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21168 )
Change subject: IMPALA-12920: Support ai_generate_text built-in function for OpenAI's chat completion API ...................................................................... Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/21168/14/be/src/exprs/ai-functions.inline.h File be/src/exprs/ai-functions.inline.h: http://gerrit.cloudera.org:8080/#/c/21168/14/be/src/exprs/ai-functions.inline.h@43 PS14, Line 43: const string AiFunctions::AI_GENERATE_TXT_JSON_PARSE_ERROR = "Invalid Json"; : const string AiFunctions::AI_GENERATE_TXT_INVALID_PROTOCOL_ERROR = : "Invalid Protocol, use https"; : const string AiFunctions::AI_GENERATE_TXT_UNSUPPORTED_ENDPOINT_ERROR = : "Unsupported Endpoint"; : const string AiFunctions::AI_GENERATE_TXT_INVALID_PROMPT_ERROR = : "Invalid Prompt, cannot be null or empty"; : const string AiFunctions::AI_GENERATE_TXT_MSG_OVERRIDE_FORBIDDEN_ERROR = : "Invalid override, 'messages' cannot be overriden"; : const string AiFunctions::AI_GENERATE_TXT_N_OVERRIDE_FORBIDDEN_ERROR = : "Invalid override, 'n' must be of integer type and have value 1"; missed static http://gerrit.cloudera.org:8080/#/c/21168/14/be/src/exprs/ai-functions.inline.h@61 PS14, Line 61: string AiFunctions::ai_api_key_; missed static -- To view, visit http://gerrit.cloudera.org:8080/21168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4446957f6030bab1f985fdd69185c3da07d7c4b Gerrit-Change-Number: 21168 Gerrit-PatchSet: 14 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 09 Apr 2024 20:07:53 +0000 Gerrit-HasComments: Yes
