Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21168 )
Change subject: IMPALA-12920: Support ai_generate_text built-in function for OpenAI's chat completion API ...................................................................... Patch Set 16: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21168/16/be/src/exprs/ai-functions.h File be/src/exprs/ai-functions.h: http://gerrit.cloudera.org:8080/#/c/21168/16/be/src/exprs/ai-functions.h@18 PS16, Line 18: #ifndef IMPALA_EXPRS_AI_FUNCTIONS_H : #define IMPALA_EXPRS_AI_FUNCTIONS_H nit. #pragma once seems simpler http://gerrit.cloudera.org:8080/#/c/21168/16/be/src/exprs/ai-functions.inline.h File be/src/exprs/ai-functions.inline.h: http://gerrit.cloudera.org:8080/#/c/21168/16/be/src/exprs/ai-functions.inline.h@18 PS16, Line 18: #ifndef IMPALA_EXPRS_AI_FUNCTIONS_INLINE_H : #define IMPALA_EXPRS_AI_FUNCTIONS_INLINE_H nit. #pragma once seems simpler, but not a big deal -- To view, visit http://gerrit.cloudera.org:8080/21168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4446957f6030bab1f985fdd69185c3da07d7c4b Gerrit-Change-Number: 21168 Gerrit-PatchSet: 16 Gerrit-Owner: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Wed, 10 Apr 2024 15:41:30 +0000 Gerrit-HasComments: Yes
