Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21258 )
Change subject: IMPALA-12810: Simplify IcebergDeleteNode and IcebergDeleteBuilder ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/21258/7/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/21258/7/be/src/runtime/krpc-data-stream-sender.cc@1125 PS7, Line 1125: Or > I can change it if you feel strong about it, but I think concise and simple I think it's a bit unexpected/abrupt after the previous paragraphs which are full sentences. In isolation it would be ok but I think it's better to match the style. http://gerrit.cloudera.org:8080/#/c/21258/8/testdata/data/README File testdata/data/README: http://gerrit.cloudera.org:8080/#/c/21258/8/testdata/data/README@1134 PS8, Line 1134: 1) Created the table via Impala and added some records to it. Could you include the CREATE TABLE and INSERT statements for reproducibility? -- To view, visit http://gerrit.cloudera.org:8080/21258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ba02b33433990950b49628f11e732e01ed8a34d Gerrit-Change-Number: 21258 Gerrit-PatchSet: 8 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 10 Apr 2024 13:19:08 +0000 Gerrit-HasComments: Yes
