Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21258 )
Change subject: IMPALA-12810: Simplify IcebergDeleteNode and IcebergDeleteBuilder ...................................................................... Patch Set 7: (1 comment) Thanks for the comment! http://gerrit.cloudera.org:8080/#/c/21258/7/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/21258/7/tests/query_test/test_iceberg.py@1455 PS7, Line 1455: if vector.get_value('exec_option')['disable_optimized_iceberg_v2_read'] == 0: > Here the code says that "if we don't disable the V2 read optimisations then Ah, those negations... you're right. Anyway, it revealed a bug in the test code that I fixed in the new PS. -- To view, visit http://gerrit.cloudera.org:8080/21258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ba02b33433990950b49628f11e732e01ed8a34d Gerrit-Change-Number: 21258 Gerrit-PatchSet: 7 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 11 Apr 2024 15:28:13 +0000 Gerrit-HasComments: Yes
