Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21297 )
Change subject: IMPALA-13001: Support graceful and force shutdown for impala.sh. ...................................................................... Patch Set 2: (3 comments) Thanks for the review! http://gerrit.cloudera.org:8080/#/c/21297/1/package/bin/impala.sh File package/bin/impala.sh: http://gerrit.cloudera.org:8080/#/c/21297/1/package/bin/impala.sh@87 PS1, Line 87: counts=20 period=2 > When performing a graceful shutdown, it's best for the script default waiti This idea is good and that's what I wanted to do at first, but that two arguments and KRPC port are passed by client, which will make the shell script too complicated. so I follow what the 'graceful_shutdown_backends.sh' script do. Maybe we can extend it in the future when we have a more graceful solution, or if you have any graceful solution now please let me known :) http://gerrit.cloudera.org:8080/#/c/21297/1/package/bin/impala.sh@106 PS1, Line 106: signal > nit: Perhaps we don't need to be too strict, that is, after echo warning me Done http://gerrit.cloudera.org:8080/#/c/21297/1/package/bin/impala.sh@262 PS1, Line 262: options:" > It needs to be updated. Done -- To view, visit http://gerrit.cloudera.org:8080/21297 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7743234952ba6b12694ecc68a920d59fea0d4ba Gerrit-Change-Number: 21297 Gerrit-PatchSet: 2 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Wed, 17 Apr 2024 14:42:43 +0000 Gerrit-HasComments: Yes
