Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/21297 )
Change subject: IMPALA-13001: Support graceful and force shutdown for impala.sh. ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21297/1/package/bin/impala.sh File package/bin/impala.sh: http://gerrit.cloudera.org:8080/#/c/21297/1/package/bin/impala.sh@87 PS1, Line 87: counts=20 period=2 > This idea is good and that's what I wanted to do at first, but that two arg Getting those two parameters is indeed tricky. One possible direction might be to try to parse these parameters from the service_flagfile (if configured), or else use the default values for these two parameters (120 and 3600). However, this might make the script overly complicated, and the decision is yours. But at least during a graceful shutdown, making the script timeout match the default values would be more reasonable. I would lean towards matching it with shutdown_grace_period_s and delaying it a bit more appropriately. http://gerrit.cloudera.org:8080/#/c/21297/2/package/bin/impala.sh File package/bin/impala.sh: http://gerrit.cloudera.org:8080/#/c/21297/2/package/bin/impala.sh@261 PS2, Line 261: restart It appears to also support -f/-g. -- To view, visit http://gerrit.cloudera.org:8080/21297 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7743234952ba6b12694ecc68a920d59fea0d4ba Gerrit-Change-Number: 21297 Gerrit-PatchSet: 2 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Tue, 23 Apr 2024 09:51:57 +0000 Gerrit-HasComments: Yes
