Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21257 )
Change subject: IMPALA-12980: Translate CpuAsk into admission control slots ...................................................................... Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/21257/15/fe/src/main/java/org/apache/impala/planner/CoreCount.java File fe/src/main/java/org/apache/impala/planner/CoreCount.java: http://gerrit.cloudera.org:8080/#/c/21257/15/fe/src/main/java/org/apache/impala/planner/CoreCount.java@132 PS15, Line 132: protected static CoreCount sum(CoreCount core1, CoreCount core2) { nit: could be implemented in terms of sum(ImmutableList.of(core1, core2)) http://gerrit.cloudera.org:8080/#/c/21257/15/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/21257/15/tests/custom_cluster/test_executor_groups.py@880 PS15, Line 880: # Add an exec group with 8 admission slots and 1 executors. This comment looks like it needs to be updated. http://gerrit.cloudera.org:8080/#/c/21257/15/tests/custom_cluster/test_executor_groups.py@886 PS15, Line 886: # Add another exec group with 8 admission slots and 3 executors. This comment looks like it needs to be updated. -- To view, visit http://gerrit.cloudera.org:8080/21257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I338ca96555bfe8d07afce0320b3688a0861663f2 Gerrit-Change-Number: 21257 Gerrit-PatchSet: 15 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 17 Apr 2024 22:04:54 +0000 Gerrit-HasComments: Yes
