Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21257 )
Change subject: IMPALA-12980: Translate CpuAsk into admission control slots ...................................................................... Patch Set 14: (5 comments) http://gerrit.cloudera.org:8080/#/c/21257/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21257/11//COMMIT_MSG@19 PS11, Line 19: stances : scheduled in this e > > So if the configuration is correct, then cpuask will be always <= the num Rephrased this paragraph. http://gerrit.cloudera.org:8080/#/c/21257/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21257/13//COMMIT_MSG@37 PS13, Line 37: > I think that it should be "more or equal" Done http://gerrit.cloudera.org:8080/#/c/21257/13/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/21257/13/be/src/scheduling/scheduler.cc@1209 PS13, Line 1209: xe > nit: "is" not needed Done http://gerrit.cloudera.org:8080/#/c/21257/13/be/src/scheduling/scheduler.cc@1209 PS13, Line 1209: n > nit: "is" Done http://gerrit.cloudera.org:8080/#/c/21257/11/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/21257/11/tests/custom_cluster/test_executor_groups.py@1245 PS11, Line 1245: # CoreCount={total=16 trace=F15:3+F01:1+F14:3+F03:1+F13:3+F05:1+F12:3+F07:1}, > Right, tpcds_cpu_cost/tpcds-q01.test is confusing here because the test has patch set 14 adds processing-cost-plan-admission-slots.test https://gerrit.cloudera.org/c/21257/14/testdata/workloads/functional-planner/queries/PlannerTest/processing-cost-plan-admission-slots.test -- To view, visit http://gerrit.cloudera.org:8080/21257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I338ca96555bfe8d07afce0320b3688a0861663f2 Gerrit-Change-Number: 21257 Gerrit-PatchSet: 14 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 16 Apr 2024 20:02:39 +0000 Gerrit-HasComments: Yes
